feat: add is_deleted soft-delete to ClickHouse IDENTITIES table#7710
Open
10done wants to merge 7 commits into
Open
feat: add is_deleted soft-delete to ClickHouse IDENTITIES table#771010done wants to merge 7 commits into
10done wants to merge 7 commits into
Conversation
|
@10done is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7710 +/- ##
==========================================
- Coverage 98.52% 98.37% -0.16%
==========================================
Files 1444 1445 +1
Lines 54971 55027 +56
==========================================
- Hits 54161 54133 -28
- Misses 810 894 +84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Fixes #7593
is_deleted Bool DEFAULT falsecolumn to the ClickHouseIDENTITIEStable via a new migrationis_deletedon every backfill row (defaults tofalse)write_identity_deletion_tombstone_to_clickhouseasync task, dispatched fromEdgeIdentity.delete()to tombstone deleted identities in real timeAND i.is_deleted = falseto the segment membership count query so deleted identities never appear in countsHow did you test this code?